Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions.* APIs and related property additions to event/interactivity payloads #1242

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Nov 22, 2023

This pull request is a prepration for #1241, which is the complete work for remote functions support. This pull request adds functions.* APIs to MethodsClient, plus adds the correspoding properties in payloads.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-app-backend labels Nov 22, 2023
@seratch seratch added this to the 1.37.0 milestone Nov 22, 2023
@seratch seratch self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (ea080c0) 74.16% compared to head (d254e67) 74.22%.

Files Patch % Lines
...on/GsonFunctionExecutedEventInputValueFactory.java 67.64% 8 Missing and 3 partials ⚠️
...m/slack/api/model/event/FunctionExecutedEvent.java 40.00% 0 Missing and 3 partials ⚠️
.../com/slack/api/methods/impl/MethodsClientImpl.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1242      +/-   ##
============================================
+ Coverage     74.16%   74.22%   +0.06%     
- Complexity     4096     4117      +21     
============================================
  Files           441      443       +2     
  Lines         13018    13077      +59     
  Branches       1310     1322      +12     
============================================
+ Hits           9655     9707      +52     
- Misses         2594     2596       +2     
- Partials        769      774       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 5f24391 into slackapi:main Nov 22, 2023
@seratch seratch deleted the remote-functions-api branch November 22, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-app-backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant