Fix #1269 A bug on the metric calculation inside async API clients #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
bug
seratch
commented
Jan 23, 2024
| @@ -80,9 +80,9 @@ public <T extends AuditApiResponse> CompletableFuture<T> execute( | |||
| }, executorService); | |||
| } | |||
|
|
|||
| private void initCurrentQueueSizeStatsIfAbsent(String teamId, String methodNameWithSuffix) { | |||
| private void syncCurrentQueueSizeStats(String teamId, String methodNameWithSuffix) { | |||
There was a problem hiding this comment.
Since this method is a private one, we can safely rename it to represent more accurate behavior.
seratch
commented
Jan 23, 2024
| @@ -264,13 +264,6 @@ public void updateCurrentQueueSize(String executorName, String teamId, String me | |||
| @Override | |||
| public void setCurrentQueueSize(String executorName, String teamId, String methodName, Integer size) { | |||
| if (this.isStatsEnabled()) { | |||
| CopyOnWriteArrayList<String> messageIds = getOrCreateMessageIds(executorName, teamId, methodName); | |||
There was a problem hiding this comment.
These lines of code are completely unnecessary. They are just an overhead when executing this method.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
============================================
+ Coverage 74.33% 74.35% +0.01%
- Complexity 4124 4125 +1
============================================
Files 443 443
Lines 13092 13080 -12
Branches 1324 1323 -1
============================================
- Hits 9732 9725 -7
+ Misses 2588 2582 -6
- Partials 772 773 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1269, thank you so much @gunrein !
The bug had been affecting only the output of the visible metrics data for developers. The internal smart rate limiter mechanism does not use the data at all, so the impact of the misbehavior should be relatively small.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.