Fix #1271 Add slack_file object to image block / block element classes #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1272 +/- ##
============================================
- Coverage 74.36% 74.30% -0.06%
- Complexity 4125 4128 +3
============================================
Files 443 444 +1
Lines 13080 13102 +22
Branches 1323 1323
============================================
+ Hits 9727 9736 +9
- Misses 2580 2594 +14
+ Partials 773 772 -1 ☔ View full report in Codecov by Sentry. |
filmaj
approved these changes
Jan 23, 2024
| assertThat(deletion.getError(), is(nullValue())); | ||
| Thread.sleep(500L); | ||
|
|
||
| ChatPostMessageResponse response = client.chatPostMessage(r -> r |
There was a problem hiding this comment.
I suppose there is no way to validate this message correctly displays the image?
There was a problem hiding this comment.
The only approach would be to check if there are the blocks in the message property in the response, but it sounds repetitive to me. Validating whether there is no error code such as invalid_blocks in the response (like the current test code does) should be good enough this time.
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1271
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.