Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the same change to chat.postMessage with #1274 #1275

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Jan 25, 2024

This pull request applies the same change with #1274 to chat.postMessage API patterns. Actually, this is not a major problem for chat.postMessage at all because the API's rate limit is pretty generous. With that being said, having this change to it as well should improve the consistency of the SDK behavior.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client labels Jan 25, 2024
@seratch seratch added this to the 1.38.1 milestone Jan 25, 2024
@seratch seratch self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c838c1) 74.49% compared to head (0a98fee) 74.53%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1275      +/-   ##
============================================
+ Coverage     74.49%   74.53%   +0.04%     
- Complexity     4135     4137       +2     
============================================
  Files           444      444              
  Lines         13108    13114       +6     
  Branches       1324     1325       +1     
============================================
+ Hits           9765     9775      +10     
+ Misses         2570     2566       -4     
  Partials        773      773              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 5f4139e into slackapi:main Jan 25, 2024
5 checks passed
@seratch seratch deleted the pr-1274-chat-postMessage branch January 25, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant