Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ignore autogenerated files created by eclipse.jdt.ls #1284

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Feb 26, 2024

This PR adds .factorypath - a file automatically created by eclipse.jdt.ls - to the project .gitignore file. The bin/ from the bolt-spring-boot-examples/spring-boot-2 project is also being generated and ignored too, but I'm not sure why only this bin/ is being generated 🤔

Category

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)
  • Other

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@zimeg zimeg added the enhancement M-T: A feature request for new functionality label Feb 26, 2024
@zimeg zimeg added this to the 1.38.2 milestone Feb 26, 2024
@zimeg zimeg requested a review from seratch February 26, 2024 23:27
@zimeg zimeg self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.34%. Comparing base (8183ad5) to head (2df7e74).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1284      +/-   ##
============================================
- Coverage     74.36%   74.34%   -0.03%     
+ Complexity     4131     4129       -2     
============================================
  Files           444      444              
  Lines         13114    13114              
  Branches       1325     1325              
============================================
- Hits           9752     9749       -3     
- Misses         2588     2590       +2     
- Partials        774      775       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch merged commit 5658430 into main Feb 26, 2024
5 checks passed
@seratch seratch deleted the build-ignore-autogenerated-lsp-files branch February 26, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants