Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests using JDK 17 #1296

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

hrothwell
Copy link
Contributor

As described in comments in #1924 - changes made to the base pom.xml here (now also present in main) should allow building all modules using JDK 17. This was tested locally using a local JDK 8 installation and JDK 17 installation, both builds pass locally. I did need to tweak the JDK 8 check locally to make sure it ran the proper JDK 8 if statement, but that shouldn't impact much if anything.

Should fix #892

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@hrothwell hrothwell changed the title update tests script Run all tests using JDK 17 Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.75%. Comparing base (71b0372) to head (1621e0a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1296   +/-   ##
=========================================
  Coverage     74.75%   74.75%           
  Complexity     4141     4141           
=========================================
  Files           442      442           
  Lines         13062    13062           
  Branches       1317     1317           
=========================================
  Hits           9765     9765           
  Misses         2534     2534           
  Partials        763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model project:slack-app-backend labels Mar 30, 2024
@seratch seratch added this to the 1.39.1 milestone Mar 30, 2024
Copy link
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, cool! Thanks for sending this PR!

@seratch seratch merged commit a114e5a into slackapi:main Mar 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed enhancement M-T: A feature request for new functionality project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model project:slack-app-backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running this SDK's unit tests in JDK 17 fails
2 participants