Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gson to the latest version #1437

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Feb 17, 2025

This pull request upgrades gson library version to the latest one. This minor version upgrade does not bring any internal changes to our enhancement, but this affect user side dependencies, so we can release as a new minor version.

Additionaly, I've confirmed micronaut minor upgrade does not require any changes, so I've included the bump too. However, http4k and ktor major upgrades seem to require code changes. Thus, I didn't touch them this time.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model dependencies Pull requests that update a dependency file labels Feb 17, 2025
@seratch seratch self-assigned this Feb 17, 2025
@seratch seratch added this to the 1.46.0 milestone Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.09%. Comparing base (236b8e9) to head (c62466d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1437      +/-   ##
============================================
+ Coverage     73.07%   73.09%   +0.02%     
- Complexity     4381     4383       +2     
============================================
  Files           475      475              
  Lines         14243    14243              
  Branches       1447     1447              
============================================
+ Hits          10408    10411       +3     
+ Misses         2977     2975       -2     
+ Partials        858      857       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@WilliamBergamin WilliamBergamin merged commit 890e7e0 into slackapi:main Feb 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file project:bolt project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants