Skip to content

use filename for uploaded files #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

use filename for uploaded files #1774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc47eb0
use filename for uploaded files
codomposer Oct 30, 2025
645e9ea
.
codomposer Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,3 +302,4 @@ helpful and collaborative way.
[slack-community]: https://slackcommunity.com/
[files_upload_v2]: https://github.com/slackapi/python-slack-sdk/releases/tag/v3.19.0
[aiohttp]: https://aiohttp.readthedocs.io/

4 changes: 2 additions & 2 deletions slack_sdk/web/internal_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,11 +345,11 @@ def _to_v2_file_upload_item(upload_file: Dict[str, Any]) -> Dict[str, Optional[A
if filename is None:
# use the local filename if filename is missing
if isinstance(file, (str, os.PathLike)):
filename = os.fspath(file).split(os.path.sep)[-1]
filename = os.path.basename(os.fspath(file))
else:
filename = "Uploaded file"

title = upload_file.get("title", "Uploaded file")
title = upload_file.get("title")
if data is None:
raise SlackRequestError(f"File content not found for filename: {filename}, title: {title}")

Expand Down