Fix: Incorrect conversion between integer types #1353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 🎟️ #1352
To fix the problem, we need to ensure that the value being converted to
uint32
is within the valid range foruint32
, which is from 0 tomath.MaxUint32
. This involves adding a lower bound check to ensure the value is not negative.The best way to fix this is to modify the
GetUint32
function to include a check for negative values before performing the conversion. This can be done by adding a condition to check if the value is less than 0 and returning the default valued
if it is.