Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Incorrect conversion between integer types #1353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

odaysec
Copy link

@odaysec odaysec commented Mar 14, 2025

Ticket 🎟️ #1352


To fix the problem, we need to ensure that the value being converted to uint32 is within the valid range for uint32, which is from 0 to math.MaxUint32. This involves adding a lower bound check to ensure the value is not negative.

The best way to fix this is to modify the GetUint32 function to include a check for negative values before performing the conversion. This can be done by adding a condition to check if the value is less than 0 and returning the default value d if it is.

Copy link

Thanks for the contribution! Before we can merge this, we need @odaysec to sign the Salesforce Inc. Contributor License Agreement.

@odaysec
Copy link
Author

odaysec commented Mar 14, 2025

/cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant