Run Slicer from the default Linux directory - #35
Open
welteki wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Use ~/slicer as the working directory for the initial Linux walkthrough and systemd daemon setup. This places slicer.sock at ~/slicer/slicer.sock, where the CLI now discovers it automatically. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
welteki
force-pushed
the
docs/linux-default-socket
branch
from
August 10, 2026 17:07
3df0b4f to
f565ed8
Compare
This comment has been minimized.
This comment has been minimized.
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)8/10. The documentation change is coherent and reproducible; remaining risk is limited to whether the new CLI discovery behavior is already released. Summary per fileSummary per file
Overall AssessmentThe scoped changes are focused and internally consistent. The walkthrough still presents the generated TCP configuration, while the daemon guide now makes the systemd setup align with the default Linux socket path and explains how the CLI selects an endpoint. The commands preserve enough working-directory context for readers to reproduce the flow. Detailed ReviewDetailed ReviewContent reviewNo blocking findings.
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Linux walkthrough and daemon guide to run Slicer from
~/slicer.The walkthrough retains the default loopback TCP endpoint, while the systemd daemon setup places its API socket at
~/slicer/slicer.sock. The daemon guide also documents the CLI endpoint discovery order and retains loopback TCP as an alternative.Motivation and Context
The Slicer CLI now discovers
~/slicer/slicer.sockby default, including when invoked throughsudo. Using~/sliceras the standard working directory aligns the documentation with this behavior while preserving the walkthrough default of listening on loopback TCP.How Has This Been Tested?
The updated commands were verified.
Types of changes
Checklist:
git commit -s