Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic accessibility like keyboard navigation (on the public facing slides) #1280

Closed
BogdanCerovac opened this issue Feb 8, 2024 · 1 comment · Fixed by #1857
Closed

Basic accessibility like keyboard navigation (on the public facing slides) #1280

BogdanCerovac opened this issue Feb 8, 2024 · 1 comment · Fixed by #1857
Labels
enhancement New feature or request pr welcome

Comments

@BogdanCerovac
Copy link
Contributor

Describe the bug
Currently only mouse reveals buttons in the (bottom) navigation, if user wants to use keyboard buttons remain hidden.

To Reproduce
Use the tab key to reach the buttons in the public facing slides, check where the focus is (in the code, you can use document.activeElement in the browser developer tools console

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome (also Edge and Firefox, it is crossbrowser issue)
  • Slidev version: 0.47.4

Possible fix
I will have to dig into code to verify this, but it seems that tailwind focus-within (https://tailwindcss.com/docs/hover-focus-and-other-states#pseudo-classes) could be used to set opacity to 100 (current classes used are opacity-0 hover:opacity-100 opacity-100).

@KermanX KermanX added the bug Something isn't working label Feb 27, 2024
@KermanX KermanX added enhancement New feature or request and removed bug Something isn't working labels Mar 15, 2024
@Goketech
Copy link
Contributor

Goketech commented Sep 8, 2024

@KermanX I made a pr to fix this issue
#1857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants