Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accessibility navigation #1857

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

Goketech
Copy link
Contributor

@Goketech Goketech commented Sep 8, 2024

This pr closes issue 1280

It adds ability to access the buttons in the (bottom) navigation, using keyboard.

Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit ebbbcfe
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/66ddbf459f14b60008a7c350
😎 Deploy Preview https://deploy-preview-1857--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Sep 8, 2024

Open in Stackblitz

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1857

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1857

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1857

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1857

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1857

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1857

commit: ebbbcfe

@Goketech
Copy link
Contributor Author

Goketech commented Sep 8, 2024

@KermanX
@antfu

@KermanX
Copy link
Member

KermanX commented Sep 8, 2024

Thank you for the PR. Could you also help to outline the navigation button when it is focused by tabbing?

By the way, in my opinion, it is not very good to ping (i.e. @) other people unless it's urgent or they haven't subscribed to this repo 😇

@Goketech
Copy link
Contributor Author

Goketech commented Sep 8, 2024

I have made the requested updates.

I am sorry about the ping.

@antfu antfu merged commit 74479ec into slidevjs:main Sep 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic accessibility like keyboard navigation (on the public facing slides)
3 participants