Skip to content

Conversation

@databasedav
Copy link
Contributor

resolves #19

@databasedav
Copy link
Contributor Author

can i remove 1.54.0 from the rust version matrix? also not sure about the crater ci error https://github.com/slint-ui/document-features/actions/runs/11755663862/job/32754124105?pr=28#step:5:137, since i still see the document-features flag here https://github.com/palfrey/serial_test/blob/3ac9744b019bee996c4d44afc72a0b1af8be1809/serial_test/Cargo.toml#L18

Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR.
I think that make sense.

Indeed, the crater error seems to be unrelated.
But let's try to keep the MSRV to a low value. So please revert the use of then_some

@ogoffart ogoffart merged commit 5237eed into slint-ui:master Nov 11, 2024
5 checks passed
@ogoffart
Copy link
Member

Thanks!

@databasedav
Copy link
Contributor Author

@ogoffart please make a new release when you get the chance, thanks 🙏

@ogoffart
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Features that are transitively enabled by default are not rendered as "(enabled by default)"

2 participants