Align DatePickerPopup and TimePickerPopup placement logic #9410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `width` and `height` properties of `DatePickerPopup` and `TimePickerPopup` components to use dynamic sizing based on `dialog` dimensions instead of fixed pixel values. Previously, the lack of `width` and `height` in `TimePickerPopup` caused inconsistent placement when displayed at a specific location: - `DatePickerPopup` was centered on the given (x, y) - `TimePickerPopup` used its top-left corner as the anchor point Now both components consistently render centered at the specified (x, y).
|
|
|
Thanks a lot for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
widthandheightproperties ofDatePickerPopupandTimePickerPopupcomponents to use dynamic sizing based ondialogdimensions instead of fixed pixel values.Previously, the lack of
widthandheightinTimePickerPopupcaused inconsistent placement when displayed at a specific location:DatePickerPopupwas centered on the given (x, y)TimePickerPopupused its top-left corner as the anchor pointNow both components consistently render centered at the specified (x, y).
Fixes #9262
Screenshots (before & after)
Before
TimePickerPopupDatePickerPopup:After
TimerPickerPopupDatePickerPopup