Open
Conversation
According to the libopenmpt docs: "Consecutive accesses can happen from different threads. ", which means all openmpt types should be Send.
Author
|
Sorry, just realised this is a duplicate of #3. I should check before I submit a PR. 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unsafely implements
sendforopenmpt::module::Module. This is safe because the openmpt documentation states:So objects created by libopenmpt are
Send, but notSync.I also fixed a few of the clippy warnings by E.G. replacing the deprecated
x...yinclusive range operator with the newerx..=y.I noticed that this repository hasn't been touched in quite a while, so I thaught I'd let you know I'd be happy to take over this project if you've lost interest / don't have the time any more. There are quite a few things I'd love to do to improve the API (better error handling, less copying when dealing with strings allocated on the libopenmpt side, etc). If you'd like to keep it though, no worries at all, just thaught I'd offer.