Fix Nondeterministic Corner Case in Receiver-Side Replay#373
Draft
Fix Nondeterministic Corner Case in Receiver-Side Replay#373
Conversation
Owner
|
@daumayr do you happen to have other code related to this? |
Contributor
Author
|
Sorry, I don't have code for this case, it was just something that i realized during writing. I can make you a sequence diagram if you want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a corner case in which the receiver-side rr is not able to capture and reproduce message orderings accurately.
The problem can occur when the following conditions are met:
Under the old replay, both messages would have the same sender/receiver promise message tuple in the trace. Hence we do not capture wether M1 or M2 is processed first.
The new solution sequentially numbers all promise messages sent by an actor, and records that number in place of the id of the resolver. replay executions automatically generate the same message numbers. In combination with the sender, this allows us to uniquely identify the promise messages and accurately reorder them.
Promise resolver tracking was removed from tracing promises.
The messageId field from Kompos tracing was reused to store message numbers.
TODO: add a testcase, do thorough testing