C# Server Plugin API (WIP) #1261
Draft
Annotations
10 errors
|
Check formatting on changed lines
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
|
Check formatting on changed lines:
Minecraft.Client/PlayerConnection.cpp#L496
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PlayerConnection.cpp:496:- {
Minecraft.Client/PlayerConnection.cpp:497:- shared_ptr<ItemInstance> selected = player->inventory->getSelected();
Minecraft.Client/PlayerConnection.cpp:498:- if (selected != nullptr && selected->count > 0)
Minecraft.Client/PlayerConnection.cpp:499:- {
Minecraft.Client/PlayerConnection.cpp:500:- int outId = selected->id, outCount = 1, outAux = selected->getAuxValue();
Minecraft.Client/PlayerConnection.cpp:501:- bool cancelled = FourKitBridge::FirePlayerDropItem(
Minecraft.Client/PlayerConnection.cpp:502:- player->entityId, selected->id, 1, selected->getAuxValue(),
Minecraft.Client/PlayerConnection.cpp:503:- &outId, &outCount, &outAux);
Minecraft.Client/PlayerConnection.cpp:504:- if (cancelled)
Minecraft.Client/PlayerConnection.cpp:505:- return;
Minecraft.Client/PlayerConnection.cpp:506:- player->inventory->removeItem(player->inventory->selected, 1);
Minecraft.Client/PlayerConnection.cpp:507:- // oops
Minecraft.Client/PlayerConnection.cpp:508:- // fix enchants disappearing
Minecraft.Client/PlayerConnection.cpp:509:- shared_ptr<ItemInstance> dropItem = (outId == selected->id)
Minecraft.Client/PlayerConnection.cpp:510:- ? selected->copy()
Minecraft.Client/PlayerConnection.cpp:511:- : std::make_shared<ItemInstance>(outId, outCount, outAux);
Minecraft.Client/PlayerConnection.cpp:512:- dropItem->count = outCount;
Minecraft.Client/PlayerConnection.cpp:513:- if (outAux != selected->getAuxValue()) dropItem->setAuxValue(outAux);
Minecraft.Client/PlayerConnection.cpp:514:- player->drop(dropItem);
Minecraft.Client/PlayerConnection.cpp:515:- return;
Minecraft.Client/PlayerConnection.cpp:516:- }
Minecraft.Client/PlayerConnection.cpp:517:- }
Minecraft.Client/PlayerConnection.cpp:496:+ {
Minecraft.Client/PlayerConnection.cpp:497:+ shared_ptr<ItemInstance> selected = player->inventory->getSelected();
Minecraft.Client/PlayerConnection.cpp:498:+ if (selected != nullptr && selected->count > 0)
Minecraft.Client/PlayerConnection.cpp:499:+ {
Minecraft.Client/PlayerConnection.cpp:500:+ int outId = selected->id, outCount = 1, outAux = selected->getAuxValue();
Minecraft.Client/PlayerConnection.cpp:501:+ bool cancelled = FourKitBridge::FirePlayerDropItem(
Minecraft.Client/PlayerConnection.cpp:502:+ player->entityId, selected->id, 1, selected->getAuxValue(),
Minecraft.Client/PlayerConnection.cpp:503:+ &outId, &outCount, &outAux);
Minecraft.Client/PlayerConnection.cpp:504:+ if (cancelled)
Minecraft.Client/PlayerConnection.cpp:505:+ {
Minecraft.Client/PlayerConnection.cpp:506:+ return;
Minecraft.Client/PlayerConnection.cpp:507:+ }
Minecraft.Client/PlayerConnection.cpp:508:+ player->inventory->removeItem(player->inventory->selected, 1);
Minecraft.Client/PlayerConnection.cpp:509:+ // oops
Minecraft.Client/PlayerConnection.cpp:510:+ // fix enchants disappearing
Minecraft.Client/PlayerConnection.cpp:511:+ shared_ptr<ItemInstance> dropItem = (outId == selected->id)
Minecraft.Client/PlayerConnection.cpp:512:+ ? selected->copy()
Minecraft.Client/PlayerConnection.cpp:513:+ : std::make_shared<ItemInstance>(outId, outCount, outAux);
Minecraft.Client/PlayerConnection.cpp:514:+ dropItem->count = outCount;
Minecraft.Client/PlayerConnection.cpp:515:+ if (outAux != selected->getAuxValue())
Minecraft.Client/PlayerConnection.cpp:516:+ {
Minecraft.Client/PlayerConnection.cpp:517:+ dropItem->setAuxValue(outAux);
Minecraft.Client/PlayerConnection.cpp:518:+ }
Minecraft.Client/PlayerConnection.cpp:519:+ player->drop(dropItem);
Minecraft.Client/PlayerConnection.cpp:520:+
|
|
Check formatting on changed lines:
Minecraft.Client/PlayerConnection.cpp#L365
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PlayerConnection.cpp:365:- if (xLastOk != xt || yLastOk != yt || zLastOk != zt || yRotT != yRotOld || xRotT != xRotOld)
Minecraft.Client/PlayerConnection.cpp:366:- {
Minecraft.Client/PlayerConnection.cpp:367:- double moveToX, moveToY, moveToZ;
Minecraft.Client/PlayerConnection.cpp:368:- bool cancelled = FourKitBridge::FirePlayerMove(player->entityId,
Minecraft.Client/PlayerConnection.cpp:369:- xLastOk, yLastOk, zLastOk,
Minecraft.Client/PlayerConnection.cpp:370:- xt, yt, zt,
Minecraft.Client/PlayerConnection.cpp:371:- &moveToX, &moveToY, &moveToZ);
Minecraft.Client/PlayerConnection.cpp:372:- if (cancelled)
Minecraft.Client/PlayerConnection.cpp:373:- {
Minecraft.Client/PlayerConnection.cpp:374:- teleport(xLastOk, yLastOk, zLastOk, yRotT, xRotT);
Minecraft.Client/PlayerConnection.cpp:375:- return;
Minecraft.Client/PlayerConnection.cpp:376:- }
Minecraft.Client/PlayerConnection.cpp:377:- if (moveToX != xt || moveToY != yt || moveToZ != zt)
Minecraft.Client/PlayerConnection.cpp:378:- {
Minecraft.Client/PlayerConnection.cpp:379:- xt = moveToX;
Minecraft.Client/PlayerConnection.cpp:380:- yt = moveToY;
Minecraft.Client/PlayerConnection.cpp:381:- zt = moveToZ;
Minecraft.Client/PlayerConnection.cpp:382:- xDist = xt - player->x;
Minecraft.Client/PlayerConnection.cpp:383:- yDist = yt - player->y;
Minecraft.Client/PlayerConnection.cpp:384:- zDist = zt - player->z;
Minecraft.Client/PlayerConnection.cpp:385:- }
Minecraft.Client/PlayerConnection.cpp:386:- }
Minecraft.Client/PlayerConnection.cpp:365:+ if (xLastOk != xt || yLastOk != yt || zLastOk != zt || yRotT != yRotOld || xRotT != xRotOld)
Minecraft.Client/PlayerConnection.cpp:366:+ {
Minecraft.Client/PlayerConnection.cpp:367:+ double moveToX, moveToY, moveToZ;
Minecraft.Client/PlayerConnection.cpp:368:+ bool cancelled = FourKitBridge::FirePlayerMove(player->entityId,
Minecraft.Client/PlayerConnection.cpp:369:+ xLastOk, yLastOk, zLastOk,
Minecraft.Client/PlayerConnection.cpp:370:+ xt, yt, zt,
Minecraft.Client/PlayerConnection.cpp:371:+ &moveToX, &moveToY, &moveToZ);
Minecraft.Client/PlayerConnection.cpp:372:+ if (cancelled)
Minecraft.Client/PlayerConnection.cpp:373:+ {
Minecraft.Client/PlayerConnection.cpp:374:+ teleport(xLastOk, yLastOk, zLastOk, yRotT, xRotT);
Minecraft.Client/PlayerConnection.cpp:375:+ return;
Minecraft.Client/PlayerConnection.cpp:376:+ }
Minecraft.Client/PlayerConnection.cpp:377:+ if (moveToX != xt || moveToY != yt || moveToZ != zt)
Minecraft.Client/PlayerConnection.cpp:378:+ {
Minecraft.Client/PlayerConnection.cpp:379:+ xt = moveToX;
Minecraft.Client/PlayerConnection.cpp:380:+ yt = moveToY;
Minecraft.Client/PlayerConnection.cpp:381:+ zt = moveToZ;
Minecraft.Client/PlayerConnection.cpp:382:+ xDist = xt - player->x;
Minecraft.Client/PlayerConnection.cpp:383:+ yDist = yt - player->y;
Minecraft.Client/PlayerConnection.cpp:384:+ zDist = zt - player->z;
Minecraft.Client/PlayerConnection.cpp:385:+ }
Minecraft.Client/PlayerConnection.cpp:386:+ }
|
|
Check formatting on changed lines:
Minecraft.Client/PlayerConnection.cpp#L299
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PlayerConnection.cpp:299:- const float yRotOld = yRotT;
Minecraft.Client/PlayerConnection.cpp:300:- const float xRotOld = xRotT;
Minecraft.Client/PlayerConnection.cpp:299:+ const float yRotOld = yRotT;
Minecraft.Client/PlayerConnection.cpp:300:+ const float xRotOld = xRotT;
|
|
Check formatting on changed lines:
Minecraft.Client/PlayerConnection.cpp#L197
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PlayerConnection.cpp:197:- if (!kickLeaveMessage.empty())
Minecraft.Client/PlayerConnection.cpp:198:- {
Minecraft.Client/PlayerConnection.cpp:199:- server->getPlayers()->broadcastAll(std::make_shared<ChatPacket>(kickLeaveMessage));
Minecraft.Client/PlayerConnection.cpp:200:- }
Minecraft.Client/PlayerConnection.cpp:201:- else if (!fourKitHandledQuit)
Minecraft.Client/PlayerConnection.cpp:202:- {
Minecraft.Client/PlayerConnection.cpp:203:- if(getWasKicked())
Minecraft.Client/PlayerConnection.cpp:204:- {
Minecraft.Client/PlayerConnection.cpp:205:- server->getPlayers()->broadcastAll(std::make_shared<ChatPacket>(player->name, ChatPacket::e_ChatPlayerKickedFromGame));
Minecraft.Client/PlayerConnection.cpp:206:- }
Minecraft.Client/PlayerConnection.cpp:207:- else
Minecraft.Client/PlayerConnection.cpp:208:- {
Minecraft.Client/PlayerConnection.cpp:209:- server->getPlayers()->broadcastAll(std::make_shared<ChatPacket>(player->name, ChatPacket::e_ChatPlayerLeftGame));
Minecraft.Client/PlayerConnection.cpp:210:- }
Minecraft.Client/PlayerConnection.cpp:211:- }
Minecraft.Client/PlayerConnection.cpp:197:+ if (!kickLeaveMessage.empty())
Minecraft.Client/PlayerConnection.cpp:198:+ {
Minecraft.Client/PlayerConnection.cpp:199:+ server->getPlayers()->broadcastAll(std::make_shared<ChatPacket>(kickLeaveMessage));
Minecraft.Client/PlayerConnection.cpp:200:+ }
Minecraft.Client/PlayerConnection.cpp:201:+ else if (!fourKitHandledQuit)
Minecraft.Client/PlayerConnection.cpp:202:+ {
Minecraft.Client/PlayerConnection.cpp:203:+ if (getWasKicked())
Minecraft.Client/PlayerConnection.cpp:204:+ {
Minecraft.Client/PlayerConnection.cpp:205:+ server->getPlayers()->broadcastAll(std::make_shared<ChatPacket>(player->name, ChatPacket::e_ChatPlayerKickedFromGame));
Minecraft.Client/PlayerConnection.cpp:206:+ }
Minecraft.Client/PlayerConnection.cpp:207:+ else
Minecraft.Client/PlayerConnection.cpp:208:+ {
Minecraft.Client/PlayerConnection.cpp:209:+ server->getPlayers()->broadcastAll(std::make_shared<ChatPacket>(player->name, ChatPacket::e_ChatPlayerLeftGame));
Minecraft.Client/PlayerConnection.cpp:210:+ }
Minecraft.Client/PlayerConnection.cpp:211:+ }
|
|
Check formatting on changed lines:
Minecraft.Client/PlayerConnection.cpp#L186
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PlayerConnection.cpp:186:- fourKitHandledQuit = FourKitBridge::FirePlayerQuit(player->entityId);
Minecraft.Client/PlayerConnection.cpp:186:+ fourKitHandledQuit = FourKitBridge::FirePlayerQuit(player->entityId);
|
|
Check formatting on changed lines:
Minecraft.Client/PlayerConnection.cpp#L169
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PlayerConnection.cpp:169:- if (reason != DisconnectPacket::eDisconnect_Closed &&
Minecraft.Client/PlayerConnection.cpp:170:- reason != DisconnectPacket::eDisconnect_ConnectionCreationFailed &&
Minecraft.Client/PlayerConnection.cpp:171:- reason != DisconnectPacket::eDisconnect_Quitting)
Minecraft.Client/PlayerConnection.cpp:172:- {
Minecraft.Client/PlayerConnection.cpp:173:- if (FourKitBridge::FirePlayerKick(player->entityId, (int)reason, kickLeaveMessage))
Minecraft.Client/PlayerConnection.cpp:174:- {
Minecraft.Client/PlayerConnection.cpp:175:- m_bWasKicked = false;
Minecraft.Client/PlayerConnection.cpp:176:- LeaveCriticalSection(&done_cs);
Minecraft.Client/PlayerConnection.cpp:177:- return;
Minecraft.Client/PlayerConnection.cpp:178:- }
Minecraft.Client/PlayerConnection.cpp:179:- }
Minecraft.Client/PlayerConnection.cpp:169:+ if (reason != DisconnectPacket::eDisconnect_Closed &&
Minecraft.Client/PlayerConnection.cpp:170:+ reason != DisconnectPacket::eDisconnect_ConnectionCreationFailed &&
Minecraft.Client/PlayerConnection.cpp:171:+ reason != DisconnectPacket::eDisconnect_Quitting)
Minecraft.Client/PlayerConnection.cpp:172:+ {
Minecraft.Client/PlayerConnection.cpp:173:+ if (FourKitBridge::FirePlayerKick(player->entityId, (int)reason, kickLeaveMessage))
Minecraft.Client/PlayerConnection.cpp:174:+ {
Minecraft.Client/PlayerConnection.cpp:175:+ m_bWasKicked = false;
Minecraft.Client/PlayerConnection.cpp:176:+ LeaveCriticalSection(&done_cs);
Minecraft.Client/PlayerConnection.cpp:177:+ return;
Minecraft.Client/PlayerConnection.cpp:178:+ }
Minecraft.Client/PlayerConnection.cpp:179:+ }
|
|
Check formatting on changed lines:
Minecraft.Client/PlayerConnection.cpp#L166
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PlayerConnection.cpp:166:- std::wstring kickLeaveMessage;
Minecraft.Client/PlayerConnection.cpp:167:- bool fourKitHandledQuit = false;
Minecraft.Client/PlayerConnection.cpp:166:+ std::wstring kickLeaveMessage;
Minecraft.Client/PlayerConnection.cpp:167:+ bool fourKitHandledQuit = false;
|
|
Check formatting on changed lines:
Minecraft.Client/PlayerConnection.cpp#L121
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PlayerConnection.cpp:121:- FourKitBridge::FirePlayerJoin(player->entityId, player->name, player->getUUID());
Minecraft.Client/PlayerConnection.cpp:121:+ FourKitBridge::FirePlayerJoin(player->entityId, player->name, player->getUUID());
|
|
Check formatting on changed lines:
Minecraft.Client/PendingConnection.cpp#L119
[clang-format] reported by reviewdog 🐶
Raw Output:
Minecraft.Client/PendingConnection.cpp:119:- std::string connectionIp = "";
Minecraft.Client/PendingConnection.cpp:120:- int connectionPort = 0;
Minecraft.Client/PendingConnection.cpp:121:-
Minecraft.Client/PendingConnection.cpp:122:- if (!connection || !connection->getSocket()) {
Minecraft.Client/PendingConnection.cpp:123:- goto handlePreLoginEND;
Minecraft.Client/PendingConnection.cpp:124:- }
Minecraft.Client/PendingConnection.cpp:125:-
Minecraft.Client/PendingConnection.cpp:126:- unsigned char smallId = connection->getSocket()->getSmallId();
Minecraft.Client/PendingConnection.cpp:127:- if (smallId == 0) {
Minecraft.Client/PendingConnection.cpp:128:- goto handlePreLoginEND;
Minecraft.Client/PendingConnection.cpp:129:- }
Minecraft.Client/PendingConnection.cpp:130:-
Minecraft.Client/PendingConnection.cpp:131:- if (!ServerRuntime::ServerLogManager::TryGetConnectionRemoteIp(smallId, &connectionIp))
Minecraft.Client/PendingConnection.cpp:132:- {
Minecraft.Client/PendingConnection.cpp:133:- SOCKET sock = WinsockNetLayer::GetSocketForSmallId(smallId);
Minecraft.Client/PendingConnection.cpp:134:- if (sock != INVALID_SOCKET)
Minecraft.Client/PendingConnection.cpp:135:- {
Minecraft.Client/PendingConnection.cpp:136:- sockaddr_in addr;
Minecraft.Client/PendingConnection.cpp:137:- int addrLen = sizeof(addr);
Minecraft.Client/PendingConnection.cpp:138:- if (getpeername(sock, (sockaddr*)&addr, &addrLen) == 0)
Minecraft.Client/PendingConnection.cpp:139:- {
Minecraft.Client/PendingConnection.cpp:140:- char ipBuf[64] = {};
Minecraft.Client/PendingConnection.cpp:141:- if (inet_ntop(AF_INET, &addr.sin_addr, ipBuf, sizeof(ipBuf)))
Minecraft.Client/PendingConnection.cpp:142:- {
Minecraft.Client/PendingConnection.cpp:143:- connectionIp = ipBuf;
Minecraft.Client/PendingConnection.cpp:144:- connectionPort = (int)ntohs(addr.sin_port);
Minecraft.Client/PendingConnection.cpp:145:- }
Minecraft.Client/PendingConnection.cpp:146:- }
Minecraft.Client/PendingConnection.cpp:147:- }
Minecraft.Client/PendingConnection.cpp:148:- if (connectionIp.empty()) {
Minecraft.Client/PendingConnection.cpp:149:- goto handlePreLoginEND;
Minecraft.Client/PendingConnection.cpp:150:- }
Minecraft.Client/PendingConnection.cpp:151:- } else {
Minecraft.Client/PendingConnection.cpp:152:- SOCKET sock = WinsockNetLayer::GetSocketForSmallId(smallId);
Minecraft.Client/PendingConnection.cpp:153:- if (sock != INVALID_SOCKET)
Minecraft.Client/PendingConnection.cpp:154:- {
Minecraft.Client/PendingConnection.cpp:155:- sockaddr_in addr;
Minecraft.Client/PendingConnection.cpp:156:- int addrLen = sizeof(addr);
Minecraft.Client/PendingConnection.cpp:157:- if (getpeername(sock, (sockaddr*)&addr, &addrLen) == 0)
Minecraft.Client/PendingConnection.cpp:158:- connectionPort = (int)ntohs(addr.sin_port);
Minecraft.Client/PendingConnection.cpp:159:- }
Minecraft.Client/PendingConnection.cpp:160:- }
Minecraft.Client/PendingConnection.cpp:161:-
Minecraft.Client/PendingConnection.cpp:162:- if (FourKitBridge::FirePlayerPreLogin(packet->loginKey, connectionIp, connectionPort)) {
Minecraft.Client/PendingConnection.cpp:163:- disconnect(DisconnectPacket::eDisconnect_EndOfStream); //idk what to use here, eventually it should be set by the event
Minecraft.Client/PendingConnection.cpp:164:- return;
Minecraft.Client/PendingConnection.cpp:165:- }
Minecraft.Client/PendingConnection.cpp:119:+ std::string connectionIp = "";
Minecraft.Client/PendingConnection.cpp:120:+ int connectionPort = 0;
Minecraft.Client/PendingConnection.cpp:121:+
Minecraft.Client/PendingConnection.cpp:122:+ if (!connection || !connection->getSocket())
Minecraft.Client/PendingConnection.cpp:123:+ {
Minecraft.Client/PendingConnection.cpp:124:+ goto handlePreLoginEND;
Minecraft.Client/PendingConnection.cpp:125:+ }
Minecraft.Client/PendingConnection.cpp:126:+
Minecraft.Client/PendingConnection.cpp:127:+ unsigned char smallId = connection->getSocket()->getSmallId();
Minecraft.Client/PendingConnection.cpp:128:+
|
Loading