Fix game crashing if DLC has XMLVERSION paramater#1285
Merged
sylvessa merged 5 commits intosmartcmd:mainfrom Mar 27, 2026
Merged
Fix game crashing if DLC has XMLVERSION paramater#1285sylvessa merged 5 commits intosmartcmd:mainfrom
sylvessa merged 5 commits intosmartcmd:mainfrom
Conversation
Draft
Collaborator
|
Shouldnt we be using the version of the dlc file not if this flag exists? |
Contributor
Author
Not possible, since .PCK version goes only from 0 to 3, and "XMLVERSION" is just a string inside the parameters which later version of the game checks for to see if it needs to offset uiFileOffset. |
GabsPuNs
added a commit
to GabsPuNs/MinecraftConsoles
that referenced
this pull request
Mar 21, 2026
Collaborator
|
Please fix the Merge Conflict, and we can get this merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash that was caused by XML Version paramater being at the spot which would be uiFileCount usually (This means the DLC has advanced BOX parameters, at least to my knowledge that's what it means).
Changes
Previous Behavior
Game would've crashed with DLCs which were too new.
Root Cause
If a DLC (.pck) had parameter "XMLVERSION" it would cause uiFileCount to be the XML version number (so a low number like 1-3).
This caused the game to crash.
New Behavior
Now it skips over the version number if it exists, and game doesn't crash.
Fix Implementation
Added a bool before parameters for-loop, check for parameter named "XMLVERSION", and after for-loop we use the bool to see if we skip 4 bytes or not so uiFileCount is correct.
AI Use Disclosure
No AI was used.
Related Issues