Disable font mipmapping to get rid of artifacts on signs#1410
Open
BotchGit wants to merge 2 commits intosmartcmd:mainfrom
Open
Disable font mipmapping to get rid of artifacts on signs#1410BotchGit wants to merge 2 commits intosmartcmd:mainfrom
BotchGit wants to merge 2 commits intosmartcmd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disables mipmapping during font rendering to remove artifacts at a distance for signs.
Changes
Uses setMipmapEnabled in Font.cpp to disable mipmapping during font rendering.
Previous Behavior
Mipmapping was done to fonts, which makes text on signs look like this from even moderately farther away:

Root Cause
Mipmapping was being applied to all fonts...
New Behavior
With mipmapping disabled signs now look like this:

Fix Implementation
See changes
AI Use Disclosure
None
Related Issues
N/A