Minor docker/container fixes and edits#1454
Merged
sylvessa merged 1 commit intosmartcmd:mainfrom Apr 2, 2026
Merged
Conversation
Collaborator
|
these r good changes. THank u for this |
itsRevela
pushed a commit
to itsRevela/MinecraftConsoles
that referenced
this pull request
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a few (no, really) simple line edits and changes for the containerized configuration and setup of the dedicated server, as these were just a few minor fixes I decided to just do it myself.
(Worth noting that I believe that the MCLCE dedicated server is unable to read
server.properties, although making that part work is outside of my available knowledge)Changes
ghcrcompose file to the right location (ghcr.io/kuwacom->ghcr.io/smartcmd)Etc/UTCtimezone by defaultghcrcompose file to the manual build one.Previous Behavior
ghcrcompose file would pull in the image fromkuwacom's account. Was most likely just overlooked during the merge of the dedicated server stuff.Asia/Tokyo.Root Cause
SERVER_PORTandSERVER_BIND_IPto25565and0.0.0.0respectively. It was not possible to change this at all unless one were to manually set the entrypoint/execution command docker used while starting the container, which isn't exactly clean.ghcrcompose file had the image value set toghcr.io/kuwacom/minecraft-lce-dedicated-server:nightly. Definitely just an overlooked leftover from the initial dedicated server pull request Implementation of Dedicated Server in Isolation #498.TZenvironment variable was initially set to${TZ:-Asia/Tokyo}.New Behavior
SERVER_BIND_IPandSERVER_PORTenvironment variables inside of the compose file/however it gets run.ghcrcompose file now pulls in fromghcr.io/smartcmd/minecraft-lce-dedicated-server:nightly.Etc/UTCas the new default timezone.720x1280x16from theghcrcompose file in the manual build compose file. Probably an unnecessary change, but uniformity + saner value imo.Fix Implementation
./docker/dedicated-server/entrypoint.shto give theSERVER_PORTandSERVER_BIND_IPvalues a user changeable value, with a default value of25565and0.0.0.0if not set by the user.imageline to point to the correctsmartcmdimage location.${TZ:-Etc/UTC}XVFB_SCREEN's value fromghcrto manual build (64x64x16->720x1280x16)AI Use Disclosure
One should not need AI to be able to make these changes tbh