fix: scale reserve amount based on decimals #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 czar0, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
markhoangcll
reviewed
Nov 4, 2025
| try token.decimals() returns (uint8 value) { | ||
| return value; | ||
| } catch { | ||
| return 18; |
There was a problem hiding this comment.
Should this be 18 as per ERC20, or 0 like datafeeds have?
Author
|
Wrapping this PR in a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reserve amount needs to be multiplied by the delta between the token decimals and its own decimals.
SecureMintPolicy.solto compute reserve scaling based on the relative token/feed decimals, defaulting to 18 when a token omitsdecimals(), preventingPolicyRunErrorhits from mocks and ensuring negative/positive margins work as intended.try/catch, keeping reserve calculations resilient against non-metadata ERC-20 implementations.