Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-5425 Introduce ConfigPollerSyncFreq #751

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

CCIP-5425 Introduce ConfigPollerSyncFreq #751

wants to merge 7 commits into from

Conversation

0xnogo
Copy link
Contributor

@0xnogo 0xnogo commented Mar 20, 2025 •
edited
Loading

  • In both Exec and Commit configs
  • Default is set to 30 sec
    core ref: e9b552d46c4a6a9b00418e1839893afd1c3b0b2c

@0xnogo 0xnogo changed the title Introduce ConfigPollerSyncDuration CCIP-5425 Introduce ConfigPollerSyncDuration Mar 20, 2025
@0xnogo 0xnogo marked this pull request as ready for review March 24, 2025 10:40
@0xnogo 0xnogo requested a review from a team as a code owner March 24, 2025 10:40
@0xnogo 0xnogo changed the title CCIP-5425 Introduce ConfigPollerSyncDuration CCIP-5425 Introduce ConfigPollerSyncFreq Mar 24, 2025
mateusz-sekara
mateusz-sekara reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@mateusz-sekara mateusz-sekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a real need to make it faster/slower on some chains? If there is no strong use case, I'm worried that we might add a new configuration param that will never be changed

@0xnogo
Copy link
Contributor Author

0xnogo commented Mar 25, 2025

@mateusz-sekara Treating all chains equally for a caching seems off. I don't think we have explored much this frequency. 30s seemed to be like a safe choice but we could potentially be more aggressive on slow chains.

@github-actions GitHub Actions
Copy link

Metric ng/ccip-5425 main
Coverage 72.2% 71.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-sekara mateusz-sekara mateusz-sekara left review comments

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xnogo @mateusz-sekara