CCIP-5425 Introduce ConfigPollerSyncFreq#751
Closed
0xnogo wants to merge 7 commits into
Closed
Conversation
0xnogo
changed the title
0xnogo
requested review from
0xAustinWang,
asoliman92,
dimkouv,
makramkd,
matYang,
mateusz-sekara and
winder
0xnogo
changed the title
mateusz-sekara
left a comment
mateusz-sekara
left a comment
Contributor
There was a problem hiding this comment.
Is there a real need to make it faster/slower on some chains? If there is no strong use case, I'm worried that we might add a new configuration param that will never be changed
Contributor
Author
|
@mateusz-sekara Treating all chains equally for a caching seems off. I don't think we have explored much this frequency. 30s seemed to be like a safe choice but we could potentially be more aggressive on slow chains. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core ref: e9b552d46c4a6a9b00418e1839893afd1c3b0b2c