-
Notifications
You must be signed in to change notification settings - Fork 21
CCIP - make required config types public and update legacy snapshot function args #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
destChainSelector ChainSelector, | ||
sourceChainSelectors []ChainSelector, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't destChainSelector
implicit? Thats the only chain the accessor is able to read from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@winder it's for this check: https://github.com/smartcontractkit/chainlink-ccip/blob/main/pkg/reader/ccip.go#L1224
the accessor needs to know which configs it should fetch (unless want to remove that check and attempt to fetch them all)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could just check if destChain
is contained within sourceChainSelectors
, but that might not be exhaustive if sourceChainSelectors
only has a subset of chains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that check staying outside of the accessor? Maybe we need a way for the accessor user to get the associated selector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that check would be within the accessor since that function is very specific to the chain reader, here is a WIP: https://github.com/smartcontractkit/chainlink-ccip/compare/cal-implement-GetAllConfigLegacySnapshot?expand=1
f87ac6b
to
7847fa7
Compare
GetAllConfigLegacySnapshot(...)
function args since it needs to have knowledge of which chain is the dest chain when constructing the batch read query