Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try immediate container cleanup #1560

Closed
wants to merge 5 commits into from
Closed

try immediate container cleanup #1560

wants to merge 5 commits into from

Conversation

tt-cll
Copy link
Collaborator

@tt-cll tt-cll commented Jan 14, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The modifications enhance the blockchain framework's flexibility and robustness, notably by integrating testing support and improving Solana container management. This ensures that containers are appropriately cleaned up during testing, preventing resource leakage.

What

  • framework/components/blockchain/blockchain.go
    • Added import for testing.
    • Introduced a new field T *testing.T in the Input struct to support testing functionalities.
  • framework/components/blockchain/solana.go
    • Introduced a cleanup step for Solana containers in testing scenarios. This ensures that containers are always cleaned up after tests, avoiding dangling resources.

@cl-sonarqube-production
Copy link

@tt-cll tt-cll closed this Jan 16, 2025
@tt-cll tt-cll deleted the tt/test branch January 16, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant