Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1608] Swaps Parrot to Chi Backend #1613

Merged
merged 5 commits into from
Jan 31, 2025
Merged

[TT-1608] Swaps Parrot to Chi Backend #1613

merged 5 commits into from
Jan 31, 2025

Conversation

kalverra
Copy link
Collaborator

@kalverra kalverra commented Jan 30, 2025

Uses Chi as the parrot backend for wildcard support


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve the performance and functionality of the parrot package by integrating a more robust router, adding new benchmarks, refining tests, and separating options into a dedicated file. These modifications facilitate better routing, testing, and configuration management.

What

  • parrot/.changeset/v0.3.0.md
    • Added details about changing to chi router and benchmark results before and after the change.
  • parrot/Makefile
    • Modified the default test log level and introduced a test timeout variable.
  • parrot/cmd/main.go
    • Updated to append recorders directly in the options setup.
  • parrot/errors.go
    • Added a new error for unhealthy server status.
  • parrot/examples_test.go
    • Simplified the deletion of routes in examples.
  • parrot/go.mod and parrot/go.sum
    • Added github.com/go-chi/chi and updated dependencies.
  • parrot/parrot.go
    • Integrated chi router, added new methods for route handling, and implemented health checking.
  • parrot/parrot_benchmark_test.go
    • Added a benchmark for getting routes.
  • parrot/parrot_options.go
    • Separated server options into a new file for better organization.
  • parrot/parrot_test.go
    • Updated tests to reflect changes in routing and error handling.
  • parrot/recorder.go and parrot/recorder_test.go
    • Improved recorder functionality and tests, including middleware for route recording.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
10.4% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube

@kalverra kalverra merged commit 99204e1 into main Jan 31, 2025
56 of 61 checks passed
@kalverra kalverra deleted the parrotChiSwap branch January 31, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants