-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi-don examples #1614
Merged
Merged
multi-don examples #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofel
reviewed
Feb 4, 2025
Tofel
reviewed
Feb 4, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The primary purpose of these changes is to enhance the configuration capabilities of the Chainlink NodeSet component within the framework. By introducing a new
name
attribute, the changes aim to provide a unique identifier for each NodeSet, allowing more granular control and identification. Additionally, modifications to the Docker-related commands and the PostgreSQL component configuration aim to improve the flexibility and cleanup process of Docker containers and volumes, thereby facilitating better resource management and isolation between tests or runs.What
name
attribute to the NodeSet configuration.postgresql_data
.name
if available.name
to the NodeSet input and adjusted Docker container naming conventions to include the NodeSet name.chainlink-testing-framework/framework
fromv0.4.7
tov0.4.8
.