Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-don examples #1614

Merged
merged 9 commits into from
Feb 4, 2025
Merged

multi-don examples #1614

merged 9 commits into from
Feb 4, 2025

Conversation

skudasov
Copy link
Collaborator

@skudasov skudasov commented Feb 3, 2025


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The primary purpose of these changes is to enhance the configuration capabilities of the Chainlink NodeSet component within the framework. By introducing a new name attribute, the changes aim to provide a unique identifier for each NodeSet, allowing more granular control and identification. Additionally, modifications to the Docker-related commands and the PostgreSQL component configuration aim to improve the flexibility and cleanup process of Docker containers and volumes, thereby facilitating better resource management and isolation between tests or runs.

What

  • book/src/framework/components/chainlink/nodeset.md, book/src/framework/components/state.md, book/src/framework/nodeset_capabilities.md, book/src/framework/nodeset_compatibility.md, book/src/framework/nodeset_docker_rebuild.md, book/src/framework/nodeset_environment.md, framework/examples/myproject/chaos.toml, framework/examples/myproject/fake.toml, framework/examples/myproject/fork_plus_offchain.toml, framework/examples/myproject/performance_baseline.toml, framework/examples/myproject/quick-deploy.toml, framework/examples/myproject/scalability.toml, framework/examples/myproject/smoke.toml, framework/examples/myproject/upgrade.toml, framework/examples/myproject/upgrade_multi.toml, framework/examples/myproject/upgrade_multi_each.toml
    • Added a name attribute to the NodeSet configuration.
  • framework/cmd/docker.go
    • Changed Docker volume cleanup command to remove all volumes instead of just postgresql_data.
  • framework/components/clnode/clnode.go
    • Modified waiting for Chainlink node startup to use a more readable format.
  • framework/components/clnode/clnode_test.go
    • Updated PostgreSQL Docker internal URL checks to reflect dynamic container naming.
  • framework/components/postgres/postgres.go
    • Adjusted container name logic for PostgreSQL, utilizing the provided name if available.
  • framework/components/simple_node_set/node_set.go
    • Introduced name to the NodeSet input and adjusted Docker container naming conventions to include the NodeSet name.
  • framework/components/simple_node_set/nodeset_test.go
    • Modified assertions to accommodate changes in PostgreSQL Docker internal URL naming.
  • framework/components/simple_node_set/reload.go
    • Updated Pumba command to use dynamic NodeSet names for container selection.
  • framework/examples/myproject/go.mod
    • Updated the version of chainlink-testing-framework/framework from v0.4.7 to v0.4.8.

@skudasov skudasov marked this pull request as ready for review February 3, 2025 19:08
@skudasov skudasov requested review from sebawo and a team as code owners February 3, 2025 19:08
@skudasov skudasov requested a review from Tofel February 3, 2025 19:08
@cl-sonarqube-production
Copy link

@skudasov skudasov merged commit 76f0f13 into main Feb 4, 2025
56 of 57 checks passed
@skudasov skudasov deleted the multiple-nodesets branch February 4, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants