Improves and standardizes Flakeguard summary data #1620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve the handling of test runs and results parsing for the Flakeguard tool. They introduce clearer structuring and naming for test data, enhance the reliability of test result analysis by adjusting for different test outcomes (e.g., skips and panics), and refine the capturing of test output based on success criteria. Notably, these adjustments aim to provide a more accurate and insightful analysis of test behavior, particularly in edge cases.
What
MaxPassRatio
toRunner
struct to explicitly define the threshold for considering tests as flaky.RunTests
to generate a summary of the test report dynamically, ensuring test outcomes like pass rates and run counts are accurately reflected in the final report.Runner
struct, ensuring tests validate the enhanced functionality correctly.