Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-804] add method that removes .run.id #814

Merged
merged 2 commits into from
Jan 11, 2024
Merged

[TT-804] add method that removes .run.id #814

merged 2 commits into from
Jan 11, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Jan 11, 2024 •
edited
Loading

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5caa538) 17.62% compared to head (9252cc0) 17.60%.
Report is 1 commits behind head on main.

Files Patch % Lines
client/mockserver.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   17.62%   17.60%   -0.02%     
==========================================
  Files          33       33              
  Lines        4222     4225       +3     
==========================================
  Hits          744      744              
- Misses       3402     3405       +3     
  Partials       76       76

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tofel Tofel marked this pull request as ready for review January 11, 2024 18:34
@Tofel Tofel requested review from sebawo and a team as code owners January 11, 2024 18:34
@Tofel Tofel merged commit 5c1a636 into main Jan 11, 2024
14 of 15 checks passed
@Tofel Tofel deleted the tt_808_clean_up_run_id branch January 11, 2024 18:43
Tofel added a commit that referenced this pull request Jan 16, 2024
@Tofel
[TT-808] add method that removes .run.id (#814)
e77fd2a
@Tofel Tofel changed the title [TT-808] add method that removes .run.id [TT-804] add method that removes .run.id Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skudasov skudasov skudasov approved these changes

@sebawo sebawo Awaiting requested review from sebawo sebawo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tofel @codecov-commenter @skudasov