[DX-2779] rename Beholder to ChIP Ingress Stack

[Tofel]

No description provided.

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[Copilot]

Pull request overview

Risk Rating: MEDIUM

This PR renames the “Beholder” concept to “Chip Ingress stack” across Local CRE tooling, system test helpers, smoke/regression tests, and documentation, while keeping backward-compatible CLI aliases and a legacy tracking metric.

Changes:

• Renamed system-test helper APIs and test scenario identifiers from Beholder to Chip Ingress stack.
• Updated Local CRE CLI to add env chip-ingress-stack commands and a new --with-chip-ingress-stack start flag, while keeping deprecated env beholder and --with-beholder aliases.
• Updated docs/READMEs and tracking metric naming to reflect the new terminology.

Targeted Review Areas (human attention)

• CLI UX/backward compatibility: ensure the deprecated env beholder ... subtree and deprecated --with-beholder flag behave exactly as intended (including banners, aliases, and stop/status flows).
• State/subscriber ID migration logic in chip_ingress_stack.go (new vs legacy subscriber-id file handling) to ensure stop/unregister always works across upgrades.
• Test suite bucketing/naming consistency (scenario enum → suite runner labels) to ensure CI selection and test output remain clear.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
system-tests/tests/test-helpers/t_helpers.go	Renames test helper entrypoints to start/assert Chip Ingress stack message consumption.
system-tests/tests/test-helpers/chip_testsink_helpers.go	Renames WatchWorkflowLogs parameters from Beholder to Chip Ingress stack terminology.
system-tests/tests/test-helpers/chip_ingress_stack_provider.go	Renames provider type/API from Beholder to ChipIngressStack; updates log/error strings and CLI subcommand invoked.
system-tests/tests/smoke/cre/README.md	Updates local run instructions to --with-chip-ingress-stack.
system-tests/tests/smoke/cre/grpc_source_test.go	Updates test run comment to new flag (with deprecation note).
system-tests/tests/smoke/cre/dontime_test.go	Updates workflow naming and expected log variable naming to Chip Ingress stack terminology.
system-tests/tests/smoke/cre/cron_chip_ingress_stack_test.go	Renames cron smoke test function and switches to Chip Ingress stack helpers.
system-tests/tests/smoke/cre/cre_suite_test.go	Updates suite scenario selection to new enum and cron test invocation.
system-tests/tests/smoke/cre/consensus_capability_test.go	Updates expected log variable naming to Chip Ingress stack terminology.
system-tests/tests/smoke/cre/config/bucketing.go	Renames suite scenario enum from CronBeholder to CronChipIngressStack and updates registry.
system-tests/tests/regression/cre/http_trigger_regression_test.go	Updates comments to Chip Ingress stack terminology.
system-tests/tests/regression/cre/http_action_regression_test.go	Updates comments/log messages to Chip Ingress stack terminology.
system-tests/tests/regression/cre/cron_chip_ingress_stack_regression_test.go	Renames cron regression test and switches to Chip Ingress stack helpers.
system-tests/tests/regression/cre/cre_regression_suite_test.go	Updates regression suite to call renamed cron regression test.
system-tests/tests/canaries_sentinels/README.md	Updates manual commands to use env chip-ingress-stack start.
docs/local-cre/system-tests/running-tests.md	Updates guidance and bucketing scenario names for Chip Ingress stack.
docs/local-cre/system-tests/index.md	Updates terminology reference from Beholder to Chip Ingress stack.
docs/local-cre/getting-started/index.md	Updates startup guidance/flag name and adds deprecation note for --with-beholder.
docs/local-cre/environment/index.md	Updates CLI flags, terminology, and port descriptions to Chip Ingress stack naming.
docs/local-cre/environment/advanced.md	Updates advanced debugging docs and option names to Chip Ingress stack.
docs/local-cre/agent-skills/local-cre-e2e/SKILL.md	Updates guidance for when to use --with-chip-ingress-stack and notes deprecation.
core/scripts/cre/environment/LOADTEST.md	Removes legacy load-test guide (no longer maintained).
core/scripts/cre/environment/environment/tracking.go	Adds new tracking metric constant while keeping legacy Beholder metric.
core/scripts/cre/environment/environment/setup.go	Updates setup output messaging to new flag naming (with deprecation note).
core/scripts/cre/environment/environment/environment.go	Adds --with-chip-ingress-stack, keeps --with-beholder alias, adds env chip-ingress-stack + deprecated env beholder command group, updates status/stop messaging, and emits both tracking metrics.
core/scripts/cre/environment/environment/chip_ingress_stack.go	Introduces chip-ingress-stack command root + deprecated beholder alias root, adds deprecation banners, updates start/stop/register logic and subscriber-id persistence handling.
core/scripts/cre/environment/configs/examples/workflow-don-overrides.toml	Updates comment command reference to env chip-ingress-stack start.
core/scripts/cre/environment/configs/chip-ingress.toml	Updates header comment to Chip Ingress stack naming.
core/scripts/cre/environment/completions.go	Updates completion tree to include chip-ingress-stack and deprecated beholder alias, plus related flag/description updates.

Comments suppressed due to low confidence (1)

system-tests/tests/test-helpers/chip_ingress_stack_provider.go:60

• The ConsumerOptions comment says defaults are applied when fields are nil/empty (including a default GroupID), but the only exported entrypoint (SubscribeToChipIngressStackMessages) always constructs a fully-populated ConsumerOptions internally and doesn’t perform any defaulting logic. Consider either implementing explicit defaulting (and accepting options from callers) or updating the comment to reflect current behavior.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.8% Duplication on New Code

See analysis details on SonarQube