refactor price into a base transport

add separate timeout for GLV info APIs tighten up vars + code fixing up tests
smartcontractkit · Feb 4, 2025 · 2799f5d · 2799f5d
1 parent 29cf6c0
commit 2799f5d
Show file tree

Hide file tree

Showing 6 changed files with 414 additions and 355 deletions.
diff --git a/.changeset/sour-glasses-travel.md b/.changeset/sour-glasses-travel.md
@@ -0,0 +1,5 @@
+---
+'@chainlink/glv-token-adapter': minor
+---
+
+Refactor price into a base transport
diff --git a/packages/composites/glv-token/src/config/index.ts b/packages/composites/glv-token/src/config/index.ts
@@ -60,6 +60,13 @@ export const config = new AdapterConfig(
       required: true,
       default: 'https://arbitrum-api.gmxinfra.io/tokens',
     },
+    GLV_INFO_API_TIMEOUT_MS: {
+      description:
+        'The amount of time the request to the GLV info APIs should wait before timing out. ' +
+        'Distinct from timeout used to make requests to the EAs which can be set with API_TIMEOUT',
+      type: 'number',
+      default: 10_000,
+    },
     METADATA_REFRESH_INTERVAL_MS: {
       description: 'The amount of time the metadata should be refreshed',
       type: 'number',

diff --git a/packages/composites/glv-token/src/endpoint/index.ts b/packages/composites/glv-token/src/endpoint/index.ts
@@ -1 +1,2 @@
 export { endpoint as price } from './price'
+export { endpoint as lwba } from './lwba'
diff --git a/packages/composites/glv-token/src/endpoint/price.ts b/packages/composites/glv-token/src/endpoint/price.ts
@@ -2,7 +2,7 @@ import { AdapterEndpoint } from '@chainlink/external-adapter-framework/adapter'
 import { InputParameters } from '@chainlink/external-adapter-framework/validation'
 import { SingleNumberResultResponse } from '@chainlink/external-adapter-framework/util'
 import { config } from '../config'
-import { glvTokenTransport } from '../transport/price'
+import { glvPriceTransport } from '../transport/price'
 
 export const inputParameters = new InputParameters(
   {
@@ -31,6 +31,6 @@ export type BaseEndpointTypes = {
 
 export const endpoint = new AdapterEndpoint({
   name: 'price',
-  transport: glvTokenTransport,
+  transport: glvPriceTransport,
   inputParameters,
 })
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		export { endpoint as price } from './price'
		export { endpoint as lwba } from './lwba'
Check failure on line 2 in packages/composites/glv-token/src/endpoint/index.ts View workflow job for this annotation GitHub Actions / Run Soak Tests Against Changed Adapters `Cannot find module './lwba' or its corresponding type declarations.` Check failure on line 2 in packages/composites/glv-token/src/endpoint/index.ts View workflow job for this annotation GitHub Actions / Install and verify dependencies `Cannot find module './lwba' or its corresponding type declarations.`