Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create clear-bank adapter #3100

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Create clear-bank adapter #3100

merged 2 commits into from
Nov 27, 2023

Conversation

amit-momin
Copy link
Contributor

@amit-momin amit-momin commented Nov 22, 2023

Closes PDI-2298

Description

Created clear-bank adapter

Steps to Test

  1. yarn test packages/sources/clear-bank/test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@amit-momin amit-momin requested a review from a team November 22, 2023 05:00
Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: 96cf684

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/clear-bank-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@amit-momin amit-momin merged commit edaab29 into main Nov 27, 2023
7 of 8 checks passed
@amit-momin amit-momin deleted the feature/clear-bank-adapter branch November 27, 2023 21:03
@github-actions github-actions bot mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants