Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ncfx forex WS auth flow #3101

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Changed ncfx forex WS auth flow #3101

merged 8 commits into from
Dec 1, 2023

Conversation

karen-stepanyan
Copy link
Contributor

@karen-stepanyan karen-stepanyan commented Nov 24, 2023

DF-19295

  1. Changed forex WS default endpoint.
  2. [Breaking] Changed forex WS auth flow. We used to generate the api key via encoding the username and password. Now the api key should be directly provided as env var.
  3. Added customInputValidation for crypto and forex endpoints.

Copy link

changeset-bot bot commented Nov 24, 2023

🦋 Changeset detected

Latest commit: f797ca5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@chainlink/ncfx-adapter Minor
@chainlink/token-allocation-adapter Patch
@chainlink/apy-finance-test-adapter Patch
@chainlink/apy-finance-adapter Patch
@chainlink/bsol-price-adapter Patch
@chainlink/crypto-volatility-index-adapter Patch
@chainlink/curve-3pool-adapter Patch
@chainlink/defi-dozen-adapter Patch
@chainlink/defi-pulse-adapter Patch
@chainlink/dxdao-adapter Patch
@chainlink/linear-finance-adapter Patch
@chainlink/savax-price-adapter Patch
@chainlink/set-token-index-adapter Patch
@chainlink/synth-index-adapter Patch
@chainlink/vesper-adapter Patch
@chainlink/xsushi-price-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@alecgard alecgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good 👍

Do we know if NCFX will support both endpoints & auth methods in parallel, or if we'll have a switchover moment where NOPs need to upgrade their EA?

@karen-stepanyan
Copy link
Contributor Author

hey @alecgard . according to the comments in the ticket, NCFX will support both endpoints until all NOPs switch to the new EA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants