Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up test #3669

Merged
merged 3 commits into from
Feb 3, 2025
Merged

fix up test #3669

merged 3 commits into from
Feb 3, 2025

Conversation

akuzni2
Copy link
Collaborator

@akuzni2 akuzni2 commented Feb 3, 2025

Fixes test result - the mock getGlvTokenPrice function was missing longTokenPrice: number[] so the minimized value was never returning

Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: c448a18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/glv-token-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@akuzni2
Copy link
Collaborator Author

akuzni2 commented Feb 3, 2025

have a larger refactor coming so want to get this test fixed so that refactor review shows that this test result doesn't change

@akuzni2 akuzni2 merged commit 29cf6c0 into main Feb 3, 2025
7 of 8 checks passed
@akuzni2 akuzni2 deleted the glv-test-update branch February 3, 2025 21:29
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
akuzni2 added a commit that referenced this pull request Feb 4, 2025
* fix up test

* fix up test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants