Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glv adapter lwba #3670

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Glv adapter lwba #3670

merged 4 commits into from
Feb 6, 2025

Conversation

akuzni2
Copy link
Collaborator

@akuzni2 akuzni2 commented Feb 4, 2025

Description

Add an LWBA endpoint

Steps to Test

  1. setup .envrc with the steps described in the readme
  2. yarn build
  3. yarn start
  4. hit the API with this request
curl -X POST \
     -H "Content-Type: application/json" \
     -d '{"data": {"endpoint":"crypto-lwba","glv": "0x528A5bac7E746C9A509A1f4F6dF58A03d44279F9"}}' \
     http://localhost:8080

you'll see lwba response format

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@akuzni2 akuzni2 requested a review from a team as a code owner February 4, 2025 00:43
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 32e0818

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/glv-token-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxiao-cll
Copy link
Contributor

Would be better if separate out into two, one just refactoring another one adding new endpoint

@akuzni2 akuzni2 changed the base branch from main to glv-adapter-refactor February 4, 2025 01:30
@akuzni2 akuzni2 force-pushed the glv-adapter-lwba branch 2 times, most recently from 92062a7 to b8d70fb Compare February 4, 2025 01:36
@akuzni2
Copy link
Collaborator Author

akuzni2 commented Feb 4, 2025

This PR builds on top of #3671

@akuzni2
Copy link
Collaborator Author

akuzni2 commented Feb 4, 2025

Would be better if separate out into two, one just refactoring another one adding new endpoint

Separated into #3671 and this one

Subarna-Singh
Subarna-Singh previously approved these changes Feb 6, 2025
Base automatically changed from glv-adapter-refactor to main February 6, 2025 15:19
@akuzni2 akuzni2 dismissed Subarna-Singh’s stale review February 6, 2025 15:19

The base branch was changed.

@akuzni2 akuzni2 requested a review from mxiao-cll February 6, 2025 17:42
@akuzni2 akuzni2 merged commit a1a5b26 into main Feb 6, 2025
7 of 8 checks passed
@akuzni2 akuzni2 deleted the glv-adapter-lwba branch February 6, 2025 17:50
@github-actions github-actions bot mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants