CM-1099 LiveArt External Adapter #4018
Conversation
…d for preparing requests and parsing response
🦋 Changeset detectedLatest commit: e2c52cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…js into feature/CM-1099_liveart_ea_nav
…matted frse files by mistake
| */ | ||
| export function parseResponse( | ||
| params: TypeFromDefinition<typeof inputParameters.definition>[], | ||
| response: AxiosResponse<ResponseSchema>, |
There was a problem hiding this comment.
Can this reference to Axios be removed?
Doesn't look like it's being used anywhere (other than a passed in type) and it's adding a bunch of new packages and preventing the checks from succeeding.
| required: true, | ||
| default: 'https://artwork-price-oracle-api-dev-ms.liveart.ai', | ||
| }, | ||
| BEARER_TOKEN: { |
There was a problem hiding this comment.
Is there an expiry date on this BEARER_TOKEN? Can you double check with the ticket reporter/API provider?
| description: 'The API URL for the LiveArt data provider', | ||
| type: 'string', | ||
| required: true, | ||
| default: 'https://artwork-price-oracle-api-dev-ms.liveart.ai', |
There was a problem hiding this comment.
this is their prod API?
| export const inputParameters = new InputParameters( | ||
| { | ||
| artwork_id: { | ||
| aliases: ['artworkId'], |
There was a problem hiding this comment.
doesn't really need an alias since this is a pretty non-standard use-case.
choose 1 and we'll go with that
| total_shares: number | null | ||
| nav_per_share: string | null | ||
| valuation_price_date: string | null | ||
| valuation_price: string | null |
There was a problem hiding this comment.
Will these be returned as explicit null or just missing from the API response ie: undefined? If just missing you can try replacing the nulls by ?:
| }) | ||
| } | ||
|
|
||
| return params.map((param: TypeFromDefinition<typeof inputParameters.definition>) => { |
There was a problem hiding this comment.
do you need this type defined here?
| params: [param], | ||
| request: { | ||
| baseURL: adapterSettings.API_BASE_URL, | ||
| url: `/artwork/${param.artwork_id}/price`, |
There was a problem hiding this comment.
this endpoint doesn't exist
Closes OPDATA-4029 / CM-1099
Description
LiveArt External Adapter (EA) to fetch art nav_per_share numerical data.
......
Changes
Steps to Test
From root directory
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file or update the soak testing blacklist.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.