change the EA to use custom transport #4041
Conversation
|
| API_FREQUENCY: { | ||
| description: 'Frequency of API calls in minutes', | ||
| type: 'number', | ||
| default: 20, |
There was a problem hiding this comment.
Can we make the default 2, as we know that works
There was a problem hiding this comment.
since there is no background process limiting here, why not 20 minutes for 6 requests ? essentially 3.3 minute per request
| sensitive: true, | ||
| }, | ||
| API_FREQUENCY: { | ||
| description: 'Frequency of API calls in minutes', |
There was a problem hiding this comment.
should this be per minute?
There was a problem hiding this comment.
this is for CRON, can be minutes or seconds I don't have preference
| schedule.scheduleJob(`0 */${this.settings.API_FREQUENCY} * * * *`, async () => { | ||
| logger.info(`Scheduled execution started at ${Date.now()}`) | ||
| for (let i = 0; i < this.params.length; i++) { | ||
| await this.executeRequest(this.params[i]) |
There was a problem hiding this comment.
Does this call the subscriptions one after the other? Does it wait 60/API_FREQUENCY seconds?
There was a problem hiding this comment.
yes, so this is make a burst of requests (once the previous one is fetched)
| } | ||
|
|
||
| runScheduler() { | ||
| schedule.scheduleJob(`0 */${this.settings.API_FREQUENCY} * * * *`, async () => { |
There was a problem hiding this comment.
How often does this make it run the cron? The superstate EA uses a const rule = new schedule.RecurrenceRule() I would be in favour of doing the same.
There was a problem hiding this comment.
this runs every this.settings.API_FREQUENCY minutes. superstate uses slightly different logic (runs at a specific time per day) so that's why it's different rule.
There was a problem hiding this comment.
Karen explained, standard cron syntax
Closes #ISSUE_NUMBER_GOES_HERE
Description
......
Changes
Steps to Test
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file or update the soak testing blacklist.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.