Update makefile deploy-rinkeby #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In .env.example, variable for etherscan api key is ETHERSCAN_KEY, while in the makefile it is ETHERSCAN_API_KEY. Adjust makefile to use ETHERSCAN_KEY so script can run using the key specified in the .env file
Author
|
can alternatively change the .env file to use ETHERSCAN_KEY |
Author
|
Hmm, still had issue using the deploy rinkeby make script, but found this issue. |
See this issue: foundry-rs/foundry#2435
Author
|
but then you have to switch to using forge create rather than the deploy script, so disregard dc0d2f8 |
|
@wk0 is there any chance you are compiling via the new intermediate representation pipeline? Verification of Yul IR bytecode on Etherscan is not currently supported, so that can also cause you to run into issues. |
Contributor
|
It looks like you took out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .env.example, variable for etherscan api key is ETHERSCAN_KEY, while in the makefile it is ETHERSCAN_API_KEY.
Adjust makefile to use ETHERSCAN_KEY so script can run using the key specified in the .env file