Enabled 3rd party imports #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeuslawyer
reviewed
Nov 28, 2023
README.md
Outdated
| @@ -6,6 +6,7 @@ Up-to-date documentation on Chainlink Functions can be found [here](https://docs | |||
|
|
|||
| # Table of Contents | |||
|
|
|||
| - [functions-toolkit](#functions-toolkit) | |||
There was a problem hiding this comment.
nit: not sure we need this in the TOC given the best it will do is move readers 9 lines up?
zeuslawyer
reviewed
Nov 28, 2023
| 'const { format } = await import("npm:date-fns"); return Functions.encodeString(format(new Date(), "yyyy-MM-dd"));', | ||
| }) | ||
|
|
||
| expect(Buffer.from(result.responseBytesHexstring?.slice(2) as string, 'hex').length).toEqual( |
There was a problem hiding this comment.
should we be testing that the import works as expected by asserting against the value of the result hex versus the length of the hex?
There was a problem hiding this comment.
If the import doesn't work, then this whole this will just throw an error, so I don't think this is needed.
There was a problem hiding this comment.
@KuphJr sorry wasnt clear- - was suggesting an alternate assert on this existing test
zeuslawyer
reviewed
Nov 28, 2023
|
SonarQube Quality Gate
|
bolekk
approved these changes
Nov 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.