[DPA-1519]: feat(solana): allow override authority on Configurer #329
Conversation
🦋 Changeset detectedLatest commit: 635b70a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
graham-chainlink
changed the title
| @@ -118,6 +132,20 @@ func TestConfigurer_SetConfig(t *testing.T) { | |||
| bindings.NewSetConfigInstructionBuilder().Build(), | |||
| }, | |||
| }, | |||
| { | |||
| name: "success - override authority", | |||
| auth: auth, | |||
There was a problem hiding this comment.
not super happy with the current testing coverage as it ignores a bunch of relevant details, but something to come back and improve.
graham-chainlink
force-pushed
the
ggoh/configure-authority
branch
from
b04fa9e to
f865c5f
Compare
When executing SetConfig via MCMS, the authority has to be the timelock signer, the current implementation does not allow any override and only accepts the `auth` or deploykey as the authority. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1519
graham-chainlink
force-pushed
the
ggoh/configure-authority
branch
from
f865c5f to
635b70a
Compare
So the main reason for this, is because in order to call setconfig via an MCMS proposal, we need to override the authority to be the timelock signer PDA instead of the deployer keys. |
@gustavogama-cll the use case is related to my SetConfig changset PR, currrently the test is failing because we have to provide the timelock signer PDA as the authority instead of the deployerKey |
Hmm... then I think we made a bad decision to change the functional option after this discussion. There doesn't seem to be a valid use case for using the two options ( |
|
I wonder should we combine them into 1 then, like |
I'd leave it as is. |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/[email protected] ### Minor Changes - [#329](#329) [`031adfb`](031adfb) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(solana): override authority on Configurer Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
When executing SetConfig via MCMS, the authority has to be the timelock signer, the current implementation does not allow any override and only accepts the `auth` or deploykey as the authority. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1519
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/[email protected] ### Minor Changes - [#329](#329) [`031adfb`](031adfb) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(solana): override authority on Configurer Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
When executing SetConfig via MCMS, the authority has to be the timelock signer, the current implementation does not allow any override and only accepts the
author deploykey as the authority.JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1519