Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 595 - Progress Bar Seek Feature #749

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented May 2, 2018

Fixes #595

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

  • Updated the current unit tests and added new ones to test OnSeekMediaClockTimer.

Summary

This PR implements the progress bar seek feature as described in the proposal.

CLA

@codecov-io
Copy link

codecov-io commented May 2, 2018

Codecov Report

Merging #749 into develop will decrease coverage by 0.2%.
The diff coverage is 30.23%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #749      +/-   ##
=============================================
- Coverage      41.01%   40.81%   -0.21%     
- Complexity      2643     2652       +9     
=============================================
  Files            362      363       +1     
  Lines          15853    16035     +182     
  Branches        1695     1723      +28     
=============================================
+ Hits            6502     6544      +42     
- Misses          9044     9186     +142     
+ Partials         307      305       -2
Impacted Files Coverage Δ Complexity Δ
...n/java/com/smartdevicelink/proxy/SdlProxyBase.java 5.32% <0%> (-0.05%) 6 <0> (ø)
...com/smartdevicelink/protocol/enums/FunctionID.java 89.89% <100%> (+0.1%) 8 <0> (ø) ⬇️
.../smartdevicelink/proxy/rpc/SetMediaClockTimer.java 100% <100%> (ø) 10 <2> (+2) ⬆️
...a/com/smartdevicelink/proxy/RPCRequestFactory.java 79.61% <25%> (-0.48%) 64 <0> (ø)
...artdevicelink/proxy/rpc/OnSeekMediaClockTimer.java 70% <70%> (ø) 4 <4> (?)
...smartdevicelink/encoder/VirtualDisplayEncoder.java 24.71% <0%> (-4.6%) 8% <0%> (ø)
...va/com/smartdevicelink/transport/TCPTransport.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...main/java/com/smartdevicelink/proxy/RPCStruct.java 77.11% <0%> (+0.84%) 38% <0%> (+1%) ⬆️
...ava/com/smartdevicelink/proxy/SdlProxyBuilder.java 63.55% <0%> (+17.71%) 2% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f940b...d9ea6ac. Read the comment docs.

@bilal-alsharifi bilal-alsharifi changed the title [WIP] Feature/issue 595 - Progress Bar Seek Feature Feature/issue 595 - Progress Bar Seek Feature May 2, 2018
public OnSeekMediaClockTimer(Hashtable<String, Object> hash) {
super(hash);
}
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add constructor with mandatory params included

* <td>Defines if seek media clock timer functionality will be available.</td>
* <td>N</td>
* <td>If omitted, the value is set to false. The value is retained until the next SetMediaClockTimer is sent.</td>
* <td>SmartDeviceLink 4.7</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be RPC spec 4.6, not 4.7

* <td>Describes the hour, minute and second values used for the current media clock timer.</td>
* <td>Y</td>
* <td></td>
* <td>SmartDeviceLink 4.7</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be RPC spec 4.6, not 4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants