Add an endpoint resolver that uses Smithy rules engine, BDD, and an interpreted bytecode VM #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
changed the title
sugmanue
reviewed
Sep 5, 2025
...client-core/src/main/java/software/amazon/smithy/java/client/core/endpoint/EndpointImpl.java
Outdated
Show resolved
Hide resolved
...rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/BytecodeWriter.java
Outdated
Show resolved
Hide resolved
...rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/BytecodeWriter.java
Outdated
Show resolved
Hide resolved
...rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/RegisterFiller.java
Outdated
Show resolved
Hide resolved
...sengine/src/main/java/software/amazon/smithy/java/client/rulesengine/RulesEngineBuilder.java
Show resolved
Hide resolved
...sengine/src/main/java/software/amazon/smithy/java/client/rulesengine/RulesEngineBuilder.java
Outdated
Show resolved
Hide resolved
...sengine/src/main/java/software/amazon/smithy/java/client/rulesengine/RulesEngineBuilder.java
Show resolved
Hide resolved
...ngine/src/test/java/software/amazon/smithy/java/client/rulesengine/BytecodeCompilerTest.java
Outdated
Show resolved
Hide resolved
sugmanue
approved these changes
Sep 5, 2025
sugmanue
approved these changes
Sep 5, 2025
|
Note: this PR is waiting on whatever the next Smithy release is after 1.61.0. |
Now the VM supports running the bytecode of a specific condition or resolving a specific result. Control flow is owned by the BddEvaluator, and VM condition handling is done through a ConditionEvaluator.
Instead of a major.minor version in the bytecode, we can just use a simpler approach of a rolling bytecode version, and more simply the version of the implementation has to be >= the version in the loaded bytecode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.