Skip to content

Conversation

@jackrein
Copy link

@jackrein jackrein commented Dec 8, 2024

The README did not mention the extension supports formatting of .smithy files. This change advertises the formatting feature and adds instructions for use

Tested auto formatting in VS code by adding and removing the block in settings.json and attempting to format via the command palette. Formatting worked when the block was there, and did not do anything when the block was omitted.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The README did not mention the extension supports formatting of
`.smithy` files. This change advertises the formatting feature
and adds instructions for use
@jackrein jackrein requested a review from a team as a code owner December 8, 2024 03:48
@jackrein jackrein requested a review from haydenbaker December 8, 2024 03:48
@yasmewad
Copy link

yasmewad commented Dec 9, 2024

Can you provider information on how did you test it?

Thanks!

@jackrein
Copy link
Author

jackrein commented Dec 9, 2024

Hey @yasmewad, I added my ad-hoc testing method to the description above

Tested auto formatting in VS code by adding and removing the block in settings.json and attempting to format via the command palette. Formatting worked when the block was there, and did not do anything when the block was omitted.

@milesziemer
Copy link
Contributor

Formatting should work without this setting, it should be automatically wired up because the language server provides it (anecdotally, I don't have it in my vscode settings, and both format on save and the Format Document command work). It may have been fixed in a newer version of the extension. Closing this for now - if you update to the latest version of the extension and still need the setting, please open an issue, as it should work without any configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants