Skip to content

Conversation

@notgull
Copy link
Member

@notgull notgull commented Dec 3, 2024

@fogti
Copy link
Member

fogti commented Dec 4, 2024

why does this justify a new minor release instead of a patch release? nothing should break if people update to this from the previous version, right?

@taiki-e
Copy link
Collaborator

taiki-e commented Dec 4, 2024

Adding a new API may break user code.

For example, adding a freestanding function/type may break code that does glob imports, and adding a method may conflict with another trait that has a method of the same name.

See also RFC 1105 for more info about which changes are considered major/minor/patch.

Signed-off-by: John Nunley <[email protected]>
@notgull
Copy link
Member Author

notgull commented Dec 31, 2024

cc @smol-rs/admins

@notgull notgull merged commit e49d025 into master Jan 12, 2025
7 checks passed
@notgull notgull deleted the notgull/next branch January 12, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants