fix(lookupDomains): absorb per-resolver failures

[wa0x6e]

Summary

Fixes STAMP-35 — a context-free Error (1589 occurrences) captured at api.ts:38.

lookupDomains fans out over [ens, shibarium, unstoppableDomains] × chains via Promise.all with no per-resolver error handling. Each resolver captures (with context) or silences its own error and then throws a bare FetchError. That rejected the whole Promise.all and propagated to the api.ts catch-all, which re-captured it as a context-stripped "Error".

Two consequences:

• Double-reporting — the real error is already captured with context at the resolver layer.
• Silencing defeated — isSilencedError (subgraph timeouts / 504 / ECONNRESET) suppresses the resolver capture, but the FetchError was still thrown and re-captured at api.ts. That's the bulk of the 1589.

Why this is the right fix

Propagation was correct in the single-resolver origin (#231), where lookupDomains was one ENS call and api.ts was its only error boundary. It was never revisited when the function became a fan-out (#362, #394) — both pure feature additions that didn't touch error handling. The sibling fan-out addressResolvers._call already swallows per-resolver failures with try { … } catch {} for exactly this reason.

This change brings lookupDomains in line with that established pattern: catch each resolver's rejection and return [], so one failing chain no longer rejects the lookup or escapes to api.ts. The api.ts catch remains a genuine safety net for unexpected errors (e.g. getOwner); informative capture + silencing stay at the resolver layer.

Behavior change

Previously, any single resolver/chain failure rejected the whole lookup_domains request → the client got a 500. Now the failing resolver contributes [] and the other chains' results are still returned → the client gets a partial 200.

This path is not cached (no redis/cache layer on lookup_domains, unlike lookup_addresses/resolve_names), so the partial result is per-request only and self-corrects on the next call — there is no risk of caching an incomplete result. The new behavior matches how addressResolvers already treats per-resolver failures.

Test plan

• Added test/unit/lookupDomains.test.ts (first unit test — fully mocked resolvers; CI runs it via test:coverage) — a resolver rejecting no longer propagates and the other resolvers' results are returned; all-fail returns []. Fails before the change, passes after.
• yarn typecheck
• yarn lint

[Copilot]

Pull request overview

This PR updates lookupDomains so per-resolver failures no longer reject the entire lookup_domains request, aligning the behavior with the existing fan-out pattern used by address resolvers.

Changes:

• Wraps each lookup domain resolver call with a fallback to [] on rejection.
• Adds unit coverage for partial resolver failure and all-resolvers-fail behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/lookupDomains/index.ts	Absorbs individual resolver rejections during domain lookup fan-out.
test/unit/lookupDomains.test.ts	Adds mocked resolver tests for partial and total resolver failure scenarios.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.