feat: Add workflow spec loader helper for medic#259
Closed
baccula wants to merge 6 commits intosnarktank:mainfrom
Closed
feat: Add workflow spec loader helper for medic#259baccula wants to merge 6 commits intosnarktank:mainfrom
baccula wants to merge 6 commits intosnarktank:mainfrom
Conversation
- Switch all workflows from 'gh pr create' to 'git-pr create' - Explicit flags: --title --description --head --base on all PR steps - Treat existing PR as success (return URL, don't fail) - Switch reviewer from gh pr to git-pr commands
…files on update, add PR_NUMBER context - Fix git-pr GitHub create path: parse args through parse_pr_create_args to translate --description to --body before calling gh pr create - Pass overwriteFiles:true during antfarm update so workspace files stay current - Add PR_NUMBER output to shared PR agent; thread into review step template - Update stale gh pr create references in comments to git-pr
- Added loadWorkflowSpecForMedic(workflowId) function in src/medic/checks.ts - Uses resolveWorkflowDir and loadWorkflowSpec to load workflow by ID - Returns null when workflow directory doesn't exist - Added tests for both null case and valid workflow case - Typecheck passes
|
Someone is attempting to deploy a commit to the Ryan Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a
loadWorkflowSpecForMedic(workflowId)helper function insrc/medic/checks.tsthat loads workflow specifications for the medic tool.Changes
loadWorkflowSpecForMedic(workflowId)function that:resolveWorkflowDirto get the workflow directory pathloadWorkflowSpecto parse the workflow spec filenullwhen workflow directory doesn't existtests/medic-workflow-loader.test.tsTesting
Notes
This is infrastructure for the medic cron gap detection feature. The actual cron gap detection logic will be implemented in subsequent stories.