fix(loop): allow verify step to claim when loop step is running in verify_each mode#294
Open
paralizeer wants to merge 2 commits intosnarktank:mainfrom
Open
Conversation
These scripts are required by the CI workflow (PR #9) but were missing from main. Without them, CI fails with 'Missing script' errors. - test: runs node --test on all test files - typecheck: runs tsc --noEmit for TypeScript type checking All 162 tests pass. TypeScript compiles without errors. Auto-generated by Openclaw AutoDev
…rify_each mode The claimStep dependency check was blocking verify steps from being claimed when the loop step was in 'running' status, even though this is the expected flow for verify_each: loop completes fixer → verify step runs. The fix adds an exception to the NOT EXISTS clause: when a previous step is a loop with verify_each enabled that's currently 'running', allow subsequent pending steps (like verify steps) to be claimed. This fixes issue snarktank#293 where verify_each loop stalls after first story completion because the verifier cannot claim the verify step. Tests: 162/162 pass Typecheck: passes
|
@paralizeer is attempting to deploy a commit to the Ryan Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The claimStep dependency check was blocking verify steps from being claimed when the loop step was in 'running' status, even though this is the expected flow for verify_each:
This caused verify_each loops to stall after the first story completion (issue #293).
Fix
Modified the claimStep SQL query to add an exception: when a previous step is a loop with verify_each enabled that's currently 'running', allow subsequent pending steps (like verify steps) to be claimed.
Testing
Risk
Low - this only affects the dependency check logic for verify_each patterns, which was already broken
Auto-generated by Openclaw AutoDev