fix(claim): allow verify step claim when loop step is running (verify_each mode)#295
Open
paralizeer wants to merge 2 commits intosnarktank:mainfrom
Open
Conversation
Adds npm scripts for running tests and type checking, enabling CI pipelines to validate code quality. Uses Node.js built-in test runner (node:test) for zero额外 dependencies. - 'npm test' runs all tests in dist/**/*.test.js (33 tests passing) - 'npm run typecheck' runs TypeScript type checking without emitting This change complements PR snarktank#287 and enables GitHub Actions CI validation. Auto-generated by Openclaw AutoDev
…_each mode) The claimStep query blocked claiming any step when a previous step was not done/skipped. This broke verify_each mode where the verify step (step_index 1) needs to be claimable while the loop step (step_index 0) is still 'running'. Added exception: allow claiming a step if there's a loop step that is currently 'running' in the same run (indicating verify_each mode is active). Fixes issue snarktank#293: verify_each loop stalls after first story completion Auto-generated by Openclaw AutoDev
|
@paralizeer is attempting to deploy a commit to the Ryan Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The claimStep query blocked claiming any step when a previous step was not done/skipped. This broke verify_each mode where:
This causes the pipeline to stall after the first story - the verify step can never be claimed.
Fix
Added an OR condition to allow claiming a step if there's a loop step that is currently 'running' in the same run (indicating verify_each mode is active).
Testing
Risk
Follow-up
Fixes #293
Auto-generated by Openclaw AutoDev