Harden workflow step output contracts#314
Draft
Christoffer91 wants to merge 4 commits intosnarktank:mainfrom
Draft
Harden workflow step output contracts#314Christoffer91 wants to merge 4 commits intosnarktank:mainfrom
Christoffer91 wants to merge 4 commits intosnarktank:mainfrom
Conversation
|
@Christoffer91 is attempting to deploy a commit to the Ryan Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens workflow step completion so step output is treated as a real runtime contract instead of best-effort text.
Changes in this PR:
STATUSon step completiondone,retry, orblocked*_JSONpayloads before merging output into run contextexpectsis not satisfiedSTATUS: blockedresearchexpectsRESEARCH_PACKET_JSON:verifyexpectsVERIFIED_PACKET_JSON:writeexpectsFINAL_REPORT:Closes #313.
Why
The main deep-research failure mode here was that malformed or incomplete verifier output could still flow downstream. This PR makes the runtime stricter so writer never runs on an invalid verified packet.
Validation
Ran:
npm run buildnode --test dist/cli/ant.test.js dist/cli/cli.test.js dist/installer/step-ops.contract.test.js dist/lib/logger.test.jsNote: there is an existing unrelated failing test in
dist/installer/status.test.json the current base branch, so I did not claim a clean full-suite pass here.