Skip to content

Fix CE due to missing snitch_main.hpp#200

Merged
tocic merged 2 commits into
mainfrom
fix_snitch_main_hpp_CE
Dec 2, 2024
Merged

Fix CE due to missing snitch_main.hpp#200
tocic merged 2 commits into
mainfrom
fix_snitch_main_hpp_CE

Conversation

@tocic

@tocic tocic commented Dec 1, 2024

Copy link
Copy Markdown
Member

Closes #199.

@codecov

codecov Bot commented Dec 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (f40e2df) to head (d11ca82).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          30       30           
  Lines        1754     1754           
=======================================
  Hits         1649     1649           
  Misses        105      105           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40e2df...d11ca82. Read the comment docs.

@cschreib

cschreib commented Dec 1, 2024

Copy link
Copy Markdown
Member

Nice catch, thanks. I've modified the install tests to use snitch.hpp instead of individual headers. Next time this happens, we'll catch it before release.

@tocic tocic merged commit 2a59433 into main Dec 2, 2024
@tocic tocic deleted the fix_snitch_main_hpp_CE branch December 2, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snitch 1.3.0: fatal error: snitch/snitch_main.hpp: No such file or directory

2 participants