Skip to content

Conversation

jochenott
Copy link
Contributor

@jochenott jochenott commented Aug 27, 2025

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

#2508

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

It adds an option to send the oauth client credentials in the request body, as defined in RFC-6749 Section 2.3.1 (as alternative).

Copy link

github-actions bot commented Aug 27, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (sfc-gh-pczajka)[https://github.com/sfc-gh-pczajka]
@jochen-ott-by
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits

@jochenott
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jochenott jochenott force-pushed the oauth-token-credentials-in-body branch from a40a7c0 to 19721ea Compare September 15, 2025 17:11
@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as ready for review September 16, 2025 09:57
@sfc-gh-pczajka sfc-gh-pczajka requested a review from a team as a code owner September 16, 2025 09:57
@sfc-gh-pczajka sfc-gh-pczajka added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Sep 16, 2025
@sfc-gh-pczajka sfc-gh-pczajka merged commit 249195a into snowflakedb:main Sep 17, 2025
38 of 92 checks passed
@sfc-gh-pczajka
Copy link
Collaborator

Thanks for the contribution!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants